Add setdomainname function#1244
Merged
Merged
Conversation
sunfishcode
reviewed
Dec 18, 2024
| name: *const c::c_char, | ||
| len: c::size_t | ||
| ) via SYS_setdomainname -> c::c_int | ||
| } |
Member
There was a problem hiding this comment.
At a quick glance, the libc crate does have declarations for setdomainname; could you comment on why tthis uses syscall! instead of just libc::setdomainname?
Contributor
Author
There was a problem hiding this comment.
Turns out libc::setdomainname isn't there for android (failed CI)
Member
There was a problem hiding this comment.
It's unfortunate to make non-Linux users use a weak symbol though. Could you use libc::setdomainname on all platforms except Android using cfgs?
I also filed rust-lang/libc#4212 to add the declarations to libc for Android.
Use weak `setdomainname` only for android; remove this special case once [libc#4212] is merged. [libc#4212]: rust-lang/libc#4212
Member
|
Thanks! |
sunfishcode
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add setdomainname function * Use `libc::setdomainname` where possible Use weak `setdomainname` only for android; remove this special case once [libc#4212] is merged. [libc#4212]: rust-lang/libc#4212 * Disable setdomainname on illumos and solaris
sunfishcode
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add setdomainname function * Use `libc::setdomainname` where possible Use weak `setdomainname` only for android; remove this special case once [libc#4212] is merged. [libc#4212]: rust-lang/libc#4212 * Disable setdomainname on illumos and solaris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.